zathras / jrpn

JRPN - A Calculator Simulator Inspired by the HP-16C "Computer Scientist" Calculator and the HP-15C Scientific Calculator
https://jrpn.jovial.com/
Other
65 stars 8 forks source link

Leading 0's (Flag #3) should be shown when entering digits in HEX,BIN,OCT modes #89

Closed meltdown03 closed 7 months ago

meltdown03 commented 8 months ago

JRPN 16C or 15C? 16C Describe the bug On the actual device, the leading 0's are visible all the time, even when entering new numbers. The 0's change to the new number. The . (decimal point in front of mode letter) is also visible if the wordsize expands beyond the current window.

To Reproduce Set flag 3 and a word size that word expose leading 0's based on the current mode, not including DEC. Enter a number and the leading 0's disappear.

Expected behavior The leading 0's and the . indicating more windows should be visible during digit entry.

Platform: Android (Beta) Linux build from latest source

Additional context Pages 47 and 49 of the manual show flag 3 set and show the leading 0's

zathras commented 7 months ago

Makes sense. I'd call this more of an enhancement. I tend to reserve "bug" for issues that cause incorrect results or other errors. This is kind of borderline maybe, but mostly cosmetic.

meltdown03 commented 7 months ago

I wasn't sure what to label it. It does make it easier to enter digits knowing how many places are left to go. Feel free to relabel it though.

On Mon, Mar 25, 2024, 11:32 AM Bill Foote @.***> wrote:

Makes sense. I'd call this more of an enhancement. I tend to reserve "bug" for issues that cause incorrect results or other errors. This is kind of borderline maybe, but mostly cosmetic.

— Reply to this email directly, view it on GitHub https://github.com/zathras/jrpn/issues/89#issuecomment-2018418635, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPBQCCGE2XXUF7YM5N7JALY2BGRTAVCNFSM6AAAAABFF5NM6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGQYTQNRTGU . You are receiving this because you authored the thread.Message ID: @.***>

zathras commented 7 months ago

@meltdown03 If you are entering digits, and so far you have entered, say, 1111 in 16 bit binary mode, does the display show "00001111 .b" or "00001111 b"? The description makes it sound like the former, but I want to be sure.

meltdown03 commented 7 months ago

It has the dot if the word size is larger than the window, yes. so 00001111 .b

On Sat, Mar 30, 2024, 10:37 AM Bill Foote @.***> wrote:

@meltdown03 https://github.com/meltdown03 If you are entering digits, and so far you have entered, say, 1111 in 16 bit binary mode, does the display show "00001111 .b" or "00001111 b"? The description makes it sound like the former, but I want to be sure.

— Reply to this email directly, view it on GitHub https://github.com/zathras/jrpn/issues/89#issuecomment-2028131517, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPBQCBBQPOMD54HQPMDZV3Y23L2XAVCNFSM6AAAAABFF5NM6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGEZTCNJRG4 . You are receiving this because you were mentioned.Message ID: @.***>

meltdown03 commented 7 months ago

This is in 16 bit wordsize 20240330_104045

zathras commented 7 months ago

@meltdown03 OK, I think that does it. Could you give it a test drive? Do you need a build for that, and if so, for what platform? (If need be, I can just publish a beta to the web.)

meltdown03 commented 7 months ago

I built it for android and it works like expected. The leading 0's and dot are there like they should be on digit entry.

On Sun, Mar 31, 2024, 1:22 PM Bill Foote @.***> wrote:

@meltdown03 https://github.com/meltdown03 OK, I think that does it. Could you give it a test drive? Do you need a build for that, and if so, for what platform? (If need be, I can just publish a beta to the web.)

— Reply to this email directly, view it on GitHub https://github.com/zathras/jrpn/issues/89#issuecomment-2028855806, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPBQCACUWNTHZI2JVNWZ4TY3BH6DAVCNFSM6AAAAABFF5NM6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYHA2TKOBQGY . You are receiving this because you were mentioned.Message ID: @.***>

zathras commented 7 months ago

Published in 2.1.13