zats / AdjustFontSize-Xcode-Plugin

Instant font size adjustment with control – / control +
270 stars 33 forks source link

Also adjust console font size #10

Closed allewun closed 9 years ago

allewun commented 9 years ago

This works, but there seems to be a small bug in Xcode. When adjusting sizes, if you switch directions (from ⌘- to ⌘+ or vice versa), the first size change is not correct. Checking the console font size in preference panel shows that it's correct, but Xcode renders it incorrectly. Any ideas?

Size (visually) Size (acutal)
Action
Before After Before After
⌘+ 10 10 10 11
⌘+ 10 11 11 12
⌘+ 11 12 12 13
⌘- 12 13 13 12
⌘- 13 12 12 11
allewun commented 9 years ago

The previous issue is now fixed. I've also separated font size changes depending on cursor focus. This lets you modify console and editor font sizes independently.

zats commented 9 years ago

Thanks for the PR, I merged it, however I modified it a bit: to keep it simple, I think it's better to modify both console & editor fonts at once. Plus some minor code changes. Nevertheless, thank you for your contribution!

allewun commented 9 years ago

I agree that simplicity is nice, but there's a benefit to having separate size controls.

A recent example (actually, this was why I decided to implement this feature):

screen shot 2015-03-11 at 1 17 02 pm copy copy

Would you consider keeping that feature? I'm currently just using my fork.

Great work on this plugin btw! Can't believe Apple chose not to include such a basic feature.

zats commented 9 years ago

hey @allewun, first of all, thank you for the contribution once again, great work! as for the merging this change back into the main trunk: I'm currently swamped with work, I hope I get a window some time soon to think of this feature.

Thanks a lot once again! You rock!

allewun commented 9 years ago

No worries @zats! I completely understand