zauberzeug / lizard

Domain-specific language to specify behaviour of microcontroller managed hardware
MIT License
15 stars 5 forks source link

Proxy defaults #97

Closed JensOgorek closed 2 days ago

JensOgorek commented 1 week ago

Handle default properties for proxies on creation without expander esp being ready.

This is a followup for #18

The defaults are handled by a static function in the module class.

JensOgorek commented 1 week ago

Replaced the static default_properties() methods with a virtual get_default_properties() function in the Module class, allowing each module type to define its own properties while eliminating the need for a separate list to maintain. Proxy will now create a temporary instance of the target module type during construction to obtain its default properties.

falkoschindler commented 3 days ago

@JensOgorek Whatever you did, somehow this PR now also contains changes from main which makes it hard to review. 😕

JensOgorek commented 3 days ago

@JensOgorek Whatever you did, somehow this PR now also contains changes from main which makes it hard to review. 😕

I got it fixed. Somehow, the main > proxy_defaults merge failed.

JensOgorek commented 3 days ago

There are still changes from main contained in this PR, like the whole "check_strapping_pins" topic in expander.cpp.

Maybe we need to start over with a fresh branch, cherry-pick individual commits and delete and burn this branch afterwards... 🔥

Good idea, I bring the flamethrower tomorrow

JensOgorek commented 2 days ago

Flamethrower was active, and we have a new pull request with #104