search

zauberzeug / rosys

An all-Python robot system based on web technologies. The purpose is similar to ROS, but it's based on NiceGUI and easier to use for mobile robotics.
https://rosys.io
MIT License
78 stars 10 forks source link

properly update settings in rtsp devices #159

Closed NiklasNeugebauer closed 2 months ago

NiklasNeugebauer commented 3 months ago

Previously, upon changing framerate and jovision profiles, the camera was configured and the gstreamer pipeline was restarted. However, the new pipeline did not actually make use of the new parameter and used the ones set during initialization of the RtspDevice instance.

This PR should fix this.

It also abstracts the settings interface away, so there will be some conflicts with #160 which should be resolved by asserting only that device is not None

NiklasNeugebauer commented 3 months ago

This should be done but I will have to test it with a real device on Monday

NiklasNeugebauer commented 2 months ago

This is ready to merge from my side

NiklasNeugebauer commented 2 months ago

ready to merge from my side