search

zaucy / zed-starlark

Zed Starlark Extension
MIT License
8 stars 5 forks source link

Update to latest extension API, misc. fixes #2

Closed alexkirsz closed 2 months ago

alexkirsz commented 4 months ago
  1. Updates to zed_extension_api = "0.0.6": a. API changes b. Use the make_file_executable method to fix an issue where the downloaded LSP binary is not executable (https://github.com/zed-industries/zed/commit/8b586ef8e7cc5aaf1917819c264be4c5efd60916)
  2. Mark WORKSPACE and BUILD files as recognized Starlark files for better Bazel support.
mik90 commented 2 months ago

I was testing out this extension today and hit the issue of the starpls binary not being marked executable which caused the lsp not to work at all (unsurprisingly). I also noticed that it didn't associate BUILD files with starlark.

I just tested out @alexkirsz's PR and it fixes both of those issues!

I was really happy to see this extension and once I got past those issues it worked really well. @zaucy would you be able to take a look at this?

zaucy commented 2 months ago

sorry, somehow this PR escaped my github notifications. I'll take a look