search

zauguin / luametalatex

18 stars 2 forks source link

Add additional `node` functions #7

Closed gucci-on-fleek closed 1 year ago

gucci-on-fleek commented 1 year ago

See #5, thanks!

zauguin commented 1 year ago

Ups, I added these before seeing the PR. Maybe the biggest code difference: Is there a reason why you want node.findattribute (without the _)? I'm currently using the approach of defining these compatibility functions only with their old name, but if you have a use case for this I'm open to defining the new names too.

gucci-on-fleek commented 1 year ago

Ups, I added these before seeing the PR

No problem. I'll close this PR.

Is there a reason why you want node.findattribute

Mostly because that's what the engine docs say the function is called:

image

(Although the engine doesn't actually define the function as listed at all...)

It doesn't really affect me either way though; my package will pick up on either function name.

gucci-on-fleek commented 1 year ago

Also, this:

https://github.com/zauguin/luametalatex/blob/d769943ce445e93e91693907e35480dd95d2c6c8/luametalatex-oldnode.lua#L53

should be

local find_attribute = direct.findattribute