search

zauguin / luapstricks

8 stars 0 forks source link

Typo fixed. #68

Closed dbitouze closed 3 years ago

dbitouze commented 3 years ago

BTW, the phrase "definefont is not implemented. Pushing dummy font." isn't clearly highlighted. Shouldn't it be a clearly visible warning?

zauguin commented 3 years ago

Thanks, but I'm not merging this since the message gets replaced instead. The old one was rather misleading (since definefont is implemented for some font types... Particularly problematic since the message was mostly shown for Type 3 fonts which actually work.)

Beside that, the warning is supposed to be rather hidden since while other fonts don't work, this is only an issue if they get used. If someone only loads some header which defines a bunch of fonts which aren't supported, then it makes sense to allow this to happen as long as noone actually tries to use them. Instead I made any attempts to use such fonts an error.