zaviagodev / e_commerce_store

Other
2 stars 4 forks source link

Storefront - Get City/State/Country to Address #111

Open chomchuen opened 4 months ago

chomchuen commented 4 months ago

Get Country list to ประเทศ field Get State list to จังหวัด field Get City list to เขต/อำเภอ field

Once 'Country' has been selected --> Filter only 'State' within that country --> if State is then selected, filter only 'City' in that state.

Check out & My Address page Image Image

AnatholyB1 commented 4 months ago

I'll look at the code and api requet for information, if well written need only 1h max, if not can go up to 3h @chomchuen @John-zaviago

chomchuen commented 4 months ago

Can you check this issue first? If the State and City structures aren't well-organized, I'll ask Muzammal to fix them. @AnatholyB1

AnatholyB1 commented 4 months ago

okay sure @chomchuen

AnatholyB1 commented 4 months ago

@chomchuen @John-zaviago this work took me more time then wanted, 7h, api is updated, but there was issue in doctype. i've added a new select for states. the flow from country -> state -> city dont have any issue but the flow up have issues sometimes. please review. and i think UX for select is not the best, we should be able to search. warning : there is to much city to be shown so when no country selected i show only thai countries

chomchuen commented 4 months ago

@AnatholyB1

I can't review due to this error.

Image

"UX" I think it's ok if users are still able to jump to them country/state/city by pressing the first letter of country/state/city name.

"Your concern" The selection of State and City should be dependent on prior selections. These two data sets should load only after users have selected higher-level data first.

For example, the State list will be fetched only when users have selected the country, and the City list will be fetched only when users have selected the state.

if no country selected, it should no any state and city there. what do yo think?

AnatholyB1 commented 4 months ago

okay I will make the revision, 30 min And you can check @chomchuen

chomchuen commented 4 months ago

@AnatholyB1 https://www.loom.com/share/c5f7a80d18e84f69a531edc7ff693ae5?sid=f605eb73-0e32-4bec-b103-8a817bbc35aa

This is UX issue that I talked about in the chat.

Please check the 'City' field. It wasn't reloaded after I changed the country.

Example: Zima is one of the cities in Ukraine However, after I changed the country to Tuvalu, the list of cities from Ukraine is still there

AnatholyB1 commented 4 months ago

okay sure let me check this, will take 10 min @chomchuen

chomchuen commented 4 months ago

@AnatholyB1 Muzammal is still working on city doctype and now he removed data in this doctype. I think we should pause this task at this moment.

AnatholyB1 commented 4 months ago

Yes I moved on already

John-zaviago commented 4 months ago

still waiting for Muzalmal

John-zaviago commented 4 months ago

moving this to @umer2001 , to optimize the delgation for tasks to finalzie storefront closer to 100%