zaviagodev / e_commerce_store

Other
2 stars 4 forks source link

Navigation Bar permission issue #58

Open chomchuen opened 7 months ago

chomchuen commented 7 months ago

Image

chomchuen commented 7 months ago

Sub-category function (which is not 'is product') doesn't work.

Image

chomchuen commented 7 months ago

Normal sub-menu is fixed but now problem is happening with 'is group' instead.

Image

I added globe icon to 'Contact Us' menu but nothing happen. Image

"Open URL in a New Tab" doesn't work as well. Image

@John-zaviago Can you confirm if we still need 'is group' feature and 'menu icon?'.

John-zaviago commented 7 months ago

Hi @chomchuen I think we still need is group feature , but menu icon was added by adam. So we can still have it there.

John-zaviago commented 7 months ago
John-zaviago commented 7 months ago

Additional meeting between Nabeel and Adam needed to discuss about background topday

John-zaviago commented 7 months ago

I will star reviewing this thing

chomchuen commented 7 months ago

Still doesn't work. And please look into these 2 function as well. Thankss🙏

@deviljutt Image

deviljutt commented 7 months ago

open in new tab part is completed

chomchuen commented 7 months ago

5/02/2024 update

John-zaviago commented 7 months ago

@deviljutt is this fixed?

  1. Need https:// before url.
  2. 'Is product' doesn't work

please double check try to close these small tasks today if able

John-zaviago commented 7 months ago

Re - assign to @AnatholyB1

AnatholyB1 commented 7 months ago

I need 4/5 hours, I will make the code clean and editable, delete unwanted part and make it simplier to read @chomchuen @John-zaviago

AnatholyB1 commented 7 months ago

@chomchuen ready for review

chomchuen commented 6 months ago

'Is product' function now meets Prim's requirements✅ but faced the getting item issue --> https://github.com/zaviagodev/e_commerce_store/issues/126.

The 2 last issue of this thread are 'https:// ' and permission issue.

  1. https://
    • Please set the condition if users didn't fill in https://, fill in for them.

Image


  1. Permission issue
    • This is my account that already have e-commerce manager role but still can't make any change to Navbar table. Can you investigate and fix permission issue? Image
AnatholyB1 commented 6 months ago

@chomchuen normally they don't need to put https:// part its working well in the code even without https://

chomchuen commented 6 months ago

Nabeel fixed url and open a new tap option then, users need to always fill in https:// . so can you fix this again? @AnatholyB1

AnatholyB1 commented 6 months ago

@chomchuen issues resolved please check, user can enter "/link" for intern link, "http" link, "https" link "www" or just normal link "youtube.com"

AnatholyB1 commented 6 months ago

and permission issue should be done aswell

chomchuen commented 6 months ago

@AnatholyB1 Url is fixed.✅

Image

Permission issue is persisting.❌

Account that faced this.

Username:

chomchuen@zaviago.com

password:

zaviago.com

Image

AnatholyB1 commented 6 months ago

@chomchuen sorry couldnt resolve the issue with permission on your account can you escalate this to upper ?

chomchuen commented 6 months ago

No problem. I'll move escalate this to Nabeel🤙