zaviagodev / frappe

MIT License
0 stars 1 forks source link

Implement Skeleton Loading to Resolve Cached Data Display Issue #166

Closed John-zaviago closed 8 months ago

John-zaviago commented 9 months ago

Issue Title: Implement Skeleton Loading to Resolve Cached Data Display Issue

Issue Description: There is an issue where, upon clicking an item to load into the item page or any other pages within tables or transactions, the old locally cached data is displayed for 2-4 seconds before updating to the new data. It is suspected that the issue is related to local cache. To resolve this, we propose implementing Skeleton loading into the Frappe core. This ensures that every time a new item is loaded, the Skeleton loading will be displayed until the new data is fetched from the database, preventing the display of outdated information during the loading period.

Steps to Reproduce:

  1. Click on an item within a table or transaction.
  2. Observe the display of old locally cached data for a brief period (2-4 seconds) during the loading time.
  3. Confirm that the data eventually updates to the correct information.

Expected Behavior: Skeleton loading should be displayed during the loading time, preventing the display of old cached data until the new data is fetched.

Additional Information:

Labels:


Action Plan:

  1. Assign the issue to a team member familiar with the Frappe core.
  2. Integrate Skeleton loading into the relevant components to display during data loading.
  3. Ensure proper synchronization with data fetching from the database.
  4. Test the implementation across various scenarios to validate its effectiveness.
  5. Communicate updates to the team and stakeholders.
  6. Monitor user feedback after the changes are deployed.
  7. Document the implementation for future reference.

John-zaviago commented 8 months ago

Not gonna work on it for now. but fix by other ways in optimizer client script of muzzalmil