search

zaviagodev / frappe

MIT License
0 stars 1 forks source link

Set 1st email/phone no. to be primary /app/contact #172

Closed chomchuen closed 7 months ago

chomchuen commented 9 months ago

This fixed✅

Conditions:

Only if users didn't check 'Is Primary' in Email ID table. and Only if users didn't check 'Is Primary Phone' and 'Is Primary Mobiles' in contact number table.

Image

chomchuen commented 9 months ago

Function works correctly✅ but has 'contact not found' warning. Please investigate and fix this issue.

Screen Shot 2567-01-09 at 15 23 29 Screen Shot 2567-01-09 at 15 24 39 Screen Shot 2567-01-09 at 15 26 20
chomchuen commented 9 months ago

'contact not found' fixed.✅

Screen Shot 2567-01-09 at 16 10 03
chomchuen commented 8 months ago

I found 2 new issue related to this function.

Issue 1

  1. Contact below is contact that I left all primary checkbox as a blank. Then, I deselected one of it. and wait for a moment (or sometime refresh the page). Checkbox that I've deselected was selected again.

Image Image

Fixed✅ Issue 2

  1. Contact didn't display email/phone number in preview even it's primary. Image Image

How to reproduce an issue.

  1. Go to customer
  2. Add contact by using this button Image
  3. Add detail and don't check primary option. Image
  4. Contact is created without primary mark. Image
  5. Go into that contact again and you will see that primary option is just checked. Image
  6. Come back to linked customer and you will see the problem. Image
Muzmal commented 8 months ago

Fixed!! Now user can deselect the option to make primary. ( Pending Review )

chomchuen commented 8 months ago

Issue 1 is fixed.✅ Issue 2 is still persisting.❌

chomchuen commented 8 months ago

Fixed✅ Issue no.2 is still persisting. Screen Shot 2567-01-24 at 18 04 31

chomchuen commented 8 months ago

This comment is fixed✅

Expectation⤵️ If meet the condition, phone no. will be both 'Primary Phone' and 'Primary Mobile' like the image below.

Screen Shot 2567-01-26 at 09 26 56

What's happening now. 'No Primary Mobile'

Screen Shot 2567-01-26 at 09 27 56

The issue above caused this issue. No Primary Mobile, then no phone mobile no. display here.

Screen Shot 2567-01-26 at 09 28 47
chomchuen commented 8 months ago

@Muzmal This is persisting. Can you check from this video?

https://www.loom.com/share/d30a04b312be4d7283de145b44f83d2d?sid=3ab93ba0-fac0-47b4-b6f2-0b870bae881c

Muzmal commented 8 months ago

Fixed. you can check

chomchuen commented 8 months ago
Screen Shot 2567-02-07 at 14 01 48 Screen Shot 2567-02-07 at 14 04 43
chomchuen commented 7 months ago

Primary phone option is working fine now.✅ Only Customer Primary Contact preview is pending.

Image

chomchuen commented 7 months ago

Need solution from Umer. So, will continue this after Muzammal and Umer don't have any urgent task left.

chomchuen commented 7 months ago

I tested with three cases: Phone number + Email, Email only, and Phone only. The issue persists only with the Phone-only case. Please check the detail below.

-> if this issue took >1.5hr, please contact me for the next step.

Phone no. + Email✅ Image

Email only✅ Image

Phone only❌ Image Image

chomchuen commented 7 months ago

Issue above is fixed.✅ @Muzmal But I just found issue when 'Saving' the document and 1 question.

  1. In this video, first, 'Did we have any script that have added to hide Enabled label??'

  2. Please focus on 'Not Saved' label. After I clicked SAVE, document was saved for a sec and instantly changed to Not Save. So I need to click SAVE button again to resolve this issue. https://www.loom.com/share/1efef102be29475cbfaa712ef6589fbd?sid=6cb28c3e-4ca4-48f9-a51c-603c94c524bb

John-zaviago commented 7 months ago

This is since Jan 8, please focus or takes contact with senior and close it within next few days @Muzmal