zaviagodev / frappe

MIT License
0 stars 1 forks source link

Removed image in Attachments on /app/item & /website-item #186

Closed chomchuen closed 5 months ago

chomchuen commented 6 months ago

How should we manage the attachments function?

The problem is, attachments that located on the left side of the interface display all images that were previously attached to the current item. As a result, some users may be confused as to why images that have been removed still appear there.

Image

chomchuen commented 6 months ago

@John-zaviago @umer2001 🙏

umer2001 commented 6 months ago

Yes I have handled this as well but I think that part of is currently not active, I will check it and enable it then both will be in sync.

On Tue, Jan 16, 2024, 1:24 PM chomchuen @.***> wrote:

How should we manage the attachments function?

The problem is, attachments that located on the left side of the interface display all images that were previously attached to the current item. As a result, some users may be confused as to why images that have been removed still appear there.

Screen.Shot.2567-01-16.at.15.07.42.png (view on web) https://github.com/zaviagodev/frappe/assets/120152434/623c0ba9-5eba-4d08-bdf7-015f540b97b5

— Reply to this email directly, view it on GitHub https://github.com/zaviagodev/frappe/issues/186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIO2A6UHARL646C64PSZI3TYOY2MLAVCNFSM6AAAAABB4MJM7WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DGMRYGYYTEOI . You are receiving this because you were assigned.Message ID: @.***>

chomchuen commented 5 months ago

Noted. @umer2001 please let me know when this's ready for review. Thank you.

umer2001 commented 5 months ago

@chomchuen its ready to test/review on tmp.zaviago.com

chomchuen commented 5 months ago

@umer2001 Thank you. I tested already. please check issue below.

Image

After refresh the page. Image I deleted still there but has removed from attachment. Image

in video. https://www.loom.com/share/8174294ca9df49319c15aa260e9469dd?sid=6e88b9eb-9884-4ede-b471-06d173566a60

John-zaviago commented 5 months ago

please push it to app.hosting @umer2001

John-zaviago commented 5 months ago

This seem to be fix