zaviagodev / frappe

MIT License
0 stars 1 forks source link

Update Clinton Sales invoice print format #233

Closed chomchuen closed 3 months ago

chomchuen commented 4 months ago

Please test on this site -> Clinton06 (Staging site)

Clinton want to reduce spacing on customer address. So I decided to get some data into the same line.

Image

please check the detail from section: Sales invoice - new getting data method for an address https://www.figma.com/file/Tu5e6wo6MWSOpD87kElnJj/Clinton-Print-Format?type=design&node-id=0%3A1&mode=design&t=1VJVs6UhobY3d1wf-1

Image

chomchuen commented 4 months ago

👀 Checked and Email and Tax Id not found. Please add email and tax id to customer address. Thank you.

Image

chomchuen commented 3 months ago

Fixed✅

chomchuen commented 3 months ago

Have an issue with blank data. Like the img below, customer doesnt have Fax and Email data but Fax: and Email: text still there. So I curious if you can create the condition to hide its text? if current customer doesnt have these data.

Image

Muzmal commented 3 months ago

image fixed

chomchuen commented 3 months ago

Fixed✅

Image

chomchuen commented 3 months ago

"New issue found"🚨

If customers used to have Phone/Fax/Email and Tax ID and was removed later, Phone/Fax/Email and Tax ID will stick to the print format.

It possible to fix this case?

Image

Muzmal commented 3 months ago

Done