Closed krish8484 closed 4 years ago
@AngryMaciek Please send me the links of the 2 dockerfiles after uploading them to dockerhub so that I can add them to the Snakefile
.
Why hasn't the travis tests started for this PR?
Why hasn't the travis tests started for this PR?
I do not know, I expect that is due to changes in the Travis config file, since there are literally no other changes to the repo(?) You need to debug this: maybe remove your changes and add them line by line?
@krish8484 : I have finished my last task here: #12 + #40 .
Since it was also related to the CI
I suggest you update your local repo to avoid conflicts later.
I have added separate builds on linux
and osx
, importantly for you:
Singularity can be installed only on linux architectures.
Therefore all your modifications should be enclosed in the if os=linux
statement - please inspect the updated .travis
to see examples.
We have the containers built:
Feels good, after finally solving the singularity issue in travis.
@AngryMaciek You may review now, let me know if anything needs changing.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #10
Type of change
Please delete options that are not relevant.
Checklist: