Closed BorisYourich closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.01
:tada:
Comparison is base (
bf11484
) 99.79% compared to head (2a4b122
) 99.80%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Sure, I'll run some tests and get back to it soon
Sure, thanks for taking the time, I will fix that soon as possible.
The issue was that I didn't consider reads that do not map at all, there is no need to include such alignments, therefore I added a check.
Okay, I just pushed the changes that Alex recommended, I think you can merge this.
Description
I have added a GetOrientation class instance in the GetLibType class so that when the sequence identifiers do not match, the files will be mapped separately. Then the alignments for each file are compared and if at least a cutoff fraction of the reads can be considered concordant, the results.relationship is changed to "split_mates".
Note that this implementation is completely written in Python and will easily become the bottleneck of the program as the logic by which the mappings are compared is all-vs-all for the two mates, so if a high fraction of reads are multi-mapping, the execution will get significantly slower
Fixes #85
Type of change
Please delete options that are not relevant.
Checklist
Please carefully read these items and tick them off if the statements are true or do not apply.
If for some reason you are unable to tick off all boxes, please leave a comment explaining the issue you are facing so that we can work on it together.