Closed dominikburri closed 1 year ago
This seems like quite a lot of work still and and we don't this to block. For now I will just require that ZARP and dependencies are installed and that the root path is passed during ZARP-cli init.
Closing for now but may be revisited in due time.
Some additional issues to consider when designing this:
zarp upgrade ...
Zarp-cli relies on other github repositories, such as
zarp
. Those need to be available for successful execution. This PR includes a new class in the modulezarp.config.init
that clones repos assubmodules
. See also the more comprehensive documentation of git submodules.Fixes #22
A simple test was added, but the functionality of downloading and preparing new repos is not yet tested. I manually ran the code and successfully cloned
zarp
into a directory of my choicesubmodules/zarp
. However, addition as test was more complicated, as some files and directories need to be deleted and use of temporary directory does not work withsubmodules
. In particular,.gitmodules
,.git/modules/
and the repo itself should be torn down after test.Remaining issues:
pandas
forzarp
execution)Type of change
Please delete options that are not relevant.
Checklist
Please carefully read these items and tick them off if the statements are true or do not apply.
If for some reason you are unable to tick off all boxes, please leave a comment explaining the issue you are facing so that we can work on it together.