zavoloklom / material-design-iconic-font

Material Design Iconic Font and CSS toolkit
http://zavoloklom.github.io/material-design-iconic-font/
Creative Commons Attribution Share Alike 4.0 International
1.42k stars 197 forks source link

Angular Material compatibility #10

Closed Swimburger closed 9 years ago

Swimburger commented 9 years ago

Many classes and directives use the prefix "md-", this causes to css of the Angular Material library to act strangely. Temporarily we have changed the prefix to "mdi-", where the "i" stands for icon.

rasmuslp commented 9 years ago

I'm confused, where does this temporary fix exist ? When I download this, the prefix is not "mdi", but just "md".

Swimburger commented 9 years ago

This is just a suggestion how you could fix it, if you have the same problem. With "we", I meant, my team. We temporarily replaced "md" to "mdi" in our Angular Material App to prevent class collision.

Swimburger commented 9 years ago

Also, I just read that scss support is added. In the _variables.scss file, you can change the variable value for the prefix. I haven't tested it though, but I will.

// Variables
// --------------------------
$md-font-path: "../fonts";
$md-css-prefix: md;
$md-version: "1.0.1";

$md-border-color: gray;

https://github.com/zavoloklom/material-design-iconic-font/blob/master/scss/_variables.scss

rasmuslp commented 9 years ago

Ah, I see. Thank you.

ghost commented 9 years ago

I'm also having this issue. It would be great if the default prefix could be something more unique.

leonzinger commented 9 years ago

+1

leonzinger commented 9 years ago

https://github.com/zavoloklom/material-design-iconic-font/pull/12

AdriVanHoudt commented 9 years ago

:+1: https://github.com/zavoloklom/material-design-iconic-font/pull/4 would also work

ghost commented 9 years ago

+1

ghost commented 9 years ago

+1

zavoloklom commented 9 years ago

Fixed in 2.0 release