search

zavtech / morpheus-core

The foundational library of the Morpheus data science framework
Apache License 2.0
238 stars 22 forks source link

Add support for reading Excel files into DataFrame #15

Closed Zavster closed 6 years ago

dgunning commented 6 years ago

Xavier ,

I have implemented reading from Excel into Morpheus DataFrames on my local branch of morpheus-core. Can I submit a pull request?

Dwight Gunning

Zavster commented 6 years ago

Sure, that would be awesome, thanks Dwight!

dgunning commented 6 years ago

Nice. Can you grant me create and push to a branch, or can you create a branch and grant me access to it. Then I can create a pull request. Alternatively I can create a pull request based on a fork, but i have already cloned and created a local branch.

Thanks

Zavster commented 6 years ago

Hey Dwight, please create a fork and then just push your branch to your fork, and you will then be able to raise a PR which I can review / merge. That's generally the workflow I use myself.

dgunning commented 6 years ago

Created pull request

Zavster commented 6 years ago

These changes have been merged and released to Maven Central as 0.9.21. Thanks