Allow setting item label via string resource

zawadz88 / MaterialPopupMenu

Shows Material popup menus grouped in sections & more

Apache License 2.0

646 stars 57 forks source link

Allow setting item label via string resource #42

Closed Tunous closed 5 years ago

Tunous commented 5 years ago

This pull request adds a way to set item labels by using string resources instead of regular strings.

Example:

val popupMenu = popupMenu {
    section {
        item {
            labelRes = R.string.copy
        }
    }
}

zawadz88 commented 5 years ago

Hi @Tunous, Thanks for dropping this PR (and the other one)! I'll review it shortly :)

Tunous commented 5 years ago

I'll review your other PRs and once they're merged I'll prepare a new release.

Cool, but you don't have to be too quick with that. I think I'll want to make at least one more pull request. (For customizable max height/width, unless that's already possible. Not sure if there'll be anything else.)