zawy12 / difficulty-algorithms

See the Issues for difficulty algorithms
MIT License
107 stars 25 forks source link

Hints for CN coins #34

Open zawy12 opened 5 years ago

zawy12 commented 5 years ago

Post a comment to this issue if we say anything important CN / Monero clones need to know. Edit your previous comment instead of adding more than 1 comment per person. I'll start.

There were some discussions yesterday about merged-mining and how to stop the capability. We are running a fork of TurtleCoin and wondering if you guys ever came up with a good solution we could start testing...?

Just do a hard fork to a new block template with no TX_Extra

RocksteadyTC commented 5 years ago

Might be good to have some sort of quote attribution so we know who to ping @zawy12

2acoin commented 5 years ago

Posted in the thread relating to the above comment...

Test BotToday at 2:42 PM
@2ACoin in case of your coin, recommendation could be the following:
- in case you don't wish to be merge-mined as a child coin (as it happens now), you should return to similar to version 1 block template as Karbo did (also @ran (BBSCoin) proposed a different trick that could work which just checks vin/vout of parent block coinbase TX)
- in case you don't wish to be merge-mined as a parent coin (in your case AEON is the parent), you should block merge mining tag in your extra, for example, as proposed by @Aiwe (Karbo), somewhere in Currency::checkProofOfWorkV1
But please note that in case of BBS coin, the merged mining is just side effect. The attack could be the same even without any merged mining.
aivve commented 5 years ago

If you don't want to be mined as parent coin, this should prevent miners include mm_tag in coinbase tx using modified daemon https://github.com/seredat/karbowanec/commit/79da48c914bf8d90d32e4ed4e8ae6564c60f3f22

Removing merged mining as slave coin is in these two commits: https://github.com/seredat/karbowanec/commit/5d4c87d5064c402bd0bcede05002b1d727dd615b https://github.com/seredat/karbowanec/commit/0ba448f4cb411023d7092a954596b3e95137c9e3