zayKenyon / VALORANT-rank-yoinker

A Python app which retrieves the VALORANT rank and players' equipped skins during a match
https://zayKenyon.github.io/VALORANT-rank-yoinker/
ISC License
433 stars 134 forks source link

Proper handling for ratelimit errors #111

Closed bigfinfrank closed 1 year ago

bigfinfrank commented 1 year ago

First time I've encountered this myself but it is a bit jarring to have the HTML of a Cloudflare page dumped into the terminal. No idea if there's a retry-after header (or similar) served but regardless in my opinion it would be preferable to at least not crash and try to update again in a few minutes or once the user has returned to the main menu state or something similar.

Error page dumped to console as HTML ``` on 0: on 0: ``` ```html Access denied | pd.na.a.pvp.net used Cloudflare to restrict access

Error 1015

Ray ID: you-dont-need-this • 2022-08-24 21:01:03 UTC

You are being rate limited

What happened?

The owner of this website (pd.na.a.pvp.net) has banned you temporarily from accessing this website.

```
OwOHamper commented 1 year ago

Already fixed in 81674c37914c50535a8d3efdcc30aff6a2be5c70