zayKenyon / VALORANT-rank-yoinker

A Python app which retrieves the VALORANT rank and players' equipped skins during a match
https://zayKenyon.github.io/VALORANT-rank-yoinker/
ISC License
433 stars 134 forks source link

Rewritten and commented src/logs.py #136

Closed ovosimpatico closed 1 year ago

ovosimpatico commented 1 year ago

The logging logic was confusing and not commented, so I've parcially rewritten the code and throughly commented it.

ovosimpatico commented 1 year ago

Just adding that it does not change any code functionality - the log will work the same way as it did before.

It's just cleaner and easier to contribute now :1st_place_medal:

zayKenyon commented 1 year ago

In general I'd say to make sure you're not stating the obvious. Common philosophy is that comments should be used when code is hard to read; when reading good code, you won't need comments. I appreciate your syntax and grammar within the comments though.

ovosimpatico commented 1 year ago

I've changed what you suggested, take a look :man_technologist:

ovosimpatico commented 1 year ago

Oh damn wrong button sorry