search

zayKenyon / VALORANT-rank-yoinker

A Python app which retrieves the VALORANT rank and players' equipped skins during a match
https://zayKenyon.github.io/VALORANT-rank-yoinker/
ISC License
433 stars 134 forks source link

New Website #171

Open thurdev opened 10 months ago

thurdev commented 10 months ago

Live preview: https://vry.thur.dev

Some screenshots and a video:

https://github.com/zayKenyon/VALORANT-rank-yoinker/assets/34294813/1e1d5dd7-38cc-4f1d-b285-260460a92a2f

Screenshot_1

Screenshot_2

Future update Ideas:

  1. If the websocket return the ranks info, would be amazing to put that on the player card component.
netlify[bot] commented 10 months ago

Deploy Preview for vry ready!

Name Link
Latest commit a08bb1845b58f3296bb5e3e8f591f345b25fff94
Latest deploy log https://app.netlify.com/sites/vry/deploys/6519e06459f94100085ada75
Deploy Preview https://deploy-preview-171--vry.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zayKenyon commented 10 months ago

This is incredibly impressive, thank you for taking the time to work on this. I'm going to go through the files later today and try to understand how it all works.

Just a couple things, the numbers in red and green next to agent names, is that HP? If so, how often does it refresh? I like the new background but I don't want to leave it as Premier for the foreseeable future and I also don't want to be frequently changing it. Is it possible for it to reflect the map the user is playing on, preferably the loading image for the map, like this?

Once again, I appreicate the PR.

thurdev commented 10 months ago

This is incredibly impressive, thank you for taking the time to work on this. I'm going to go through the files later today and try to understand how it all works.

Just a couple things, the numbers in red and green next to agent names, is that HP? If so, how often does it refresh? I like the new background but I don't want to leave it as Premier for the foreseeable future and I also don't want to be frequently changing it. Is it possible for it to reflect the map the user is playing on, preferably the loading image for the map, like this?

Once again, I appreicate the PR.

Hey, great to hear from you!

So the numbers close to the agent names is the players levels.

Agree with you about the background image, would be great to show the current map, but yeah also I need that information from the websocket response.

So If possible return 2 new things on the websocket:

  1. Current Map - Wallpaper & Name
  2. Players Ranks - Rank Name & Icon

Also, if needed understanding the code you can send-me a message on discord: thurdev, and I can help with further questions.

0xfalls commented 10 months ago

Can you add gun buddy?

thurdev commented 10 months ago

Can you add gun buddy?

Yes, I just need that to be returned from the websocket aswell, not sure if already returns or not.

zayKenyon commented 10 months ago

Map assets added and it does already send buddies. But, adding ranks to this should require overhauling the Loadouts class to better reflect what it has now become which I do not really want to do at the moment.

OwOHamper commented 9 months ago

I have merged https://github.com/zayKenyon/VALORANT-rank-yoinker/pull/113, which should have everything if not more in the websocket response.

thurdev commented 8 months ago

Leaving explicit credit within the product is not something we have historically done. If I were a user and I clicked the GitHub button I would expect to be taken to the product's GitHub page, not a (seemingly!) random user account.

Please contact me via the Discord if you would like to work out a different arrangement.

Don't worry, I left as a contact way, will remove it as soon as a make a new commit.