zayKenyon / VALORANT-rank-yoinker

A Python app which retrieves the VALORANT rank and players' equipped skins during a match
https://zayKenyon.github.io/VALORANT-rank-yoinker/
ISC License
453 stars 141 forks source link

In game names. #58

Closed PaulinaSzreder closed 2 years ago

PaulinaSzreder commented 2 years ago

Does your "feature" show in game names even if player don't wish to?

D3CRYPT360 commented 2 years ago

yes, players with streamer mode on will still be shown on the app with their user name.

PaulinaSzreder commented 2 years ago

Not cool, the streamer mode is made for something.

D3CRYPT360 commented 2 years ago

Well, it's not our fault that the riot's own API shows that data. If you would like an application which does hide the names if a person has streamer mode on but is like vry I would recommend checking out https://waiua.sonel.dev/ .

PaulinaSzreder commented 2 years ago

It's yours because you made this app. You could made is better.

PaulinaSzreder commented 2 years ago

And also Riot API show if player is Incognito and if Account level is shown. You should respect that.

Zephira58 commented 2 years ago

Hey don't mean to butt in here but there's tons of alternatives that may be better suited to your needs @PaulinaSzreder this may include but is not limited to.

https://waiua.sonel.dev/ https://tracker.gg/valorant

I highly recommend you try those out if your unhappy with the current application

PaulinaSzreder commented 2 years ago

I don't need these kind of app, but your app help to stream sniping. You should change that.

Zephira58 commented 2 years ago

I'm not a developer here so I'm not sure if they are going to implement that feature; if its something you would like to see you can offer to make a pull request or fork the application and make your own version with any modifications you want to see. Just make sure that whatever you wish to do falls under the M.I.T License

zayKenyon commented 2 years ago

Not cool, the streamer mode is made for something.

Then riot themselves should respect that instead of leaving it up to the developers.

OwOHamper commented 2 years ago

Well if riot provides that data we will show them in the app. If we would hide it people would use more alternatives and believe me even if we would hide it it would not fix the problem, riot need to fix it on their side.