search

zaycation / jewel-jack

A react based successor to blackjack - with jewels of course!!
4 stars 5 forks source link

Jewels never return 0 now #7

Closed xaerru closed 3 years ago

xaerru commented 3 years ago

Change the getRandomNumberBetween range to exclude 0.

xaerru commented 3 years ago

The if statements didn't do anything earlier because when the value was 0 the currentCount would be 0. If statements aren't needed after the fix too.

xaerru commented 3 years ago

Fixes #1

zaycation commented 3 years ago

Thanks! I totally see the no need for if statements after the changes. Nice job! Another contributor is working on the wall of fame for us and hopefully we'll see that in the next coming days. Also, we have a coding discord for help and general chat if you'd like to be in it, come join us: https://discord.gg/PFxWBe4