PR#28 breaks rendering on 3080Ti

zaycev / bevy-magic-light-2d

Experiment with computing 2D shading, lighting and shadows with Bevy Engine

Apache License 2.0

427 stars 37 forks source link

PR#28 breaks rendering on 3080Ti #30

Closed 00alia00 closed 8 months ago

00alia00 commented 10 months ago

Looks like PR#28 causes rendering to break on my laptop

krypta_AhEssZfTKa

AdapterInfo { name: "NVIDIA GeForce RTX 3080 Ti Laptop GPU", vendor: 4318, device: 9248, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "517.40", backend: Vulkan }
SystemInfo { os: "Windows 11 Pro", kernel: "22621", cpu: "12th Gen Intel(R) Core(TM) i9-12900H", core_count: "14", memory: "31.7 GiB" }

zaycev commented 10 months ago

Will try to take a look this week. Likely I have the same GPU :)

aMyTimed commented 9 months ago

any update?

0xD21F commented 9 months ago

I can confirm the same issue, 3080Ti also.

AdapterInfo { name: "NVIDIA GeForce RTX 3080 Ti", vendor: 4318, device: 8712, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "516.94", backend: Vulkan }
SystemInfo { os: "Windows 11 Pro", kernel: "22000", cpu: "AMD Ryzen 9 5900X 12-Core Processor", core_count: "12", memory: "63.9 GiB" }

If I roll back PR#28, it begins to work again.

awski commented 9 months ago

Not sure if that's helpful, but it also doesn't work on 2070S

AdapterInfo { name: "NVIDIA GeForce RTX 2070 SUPER", vendor: 4318, device: 7812, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "545.84", backend: Vulkan } SystemInfo { os: "Windows 11 Pro", kernel: "22621", cpu: "AMD Ryzen 7 2700X Eight-Core Processor", core_count: "8", memory: "32.0 GiB" }

zaycev commented 8 months ago

Should be fixed on main. Compositing pass which blends multiple layers was broken when we accidentally changed clear color to black instead of transparent in krypta example.

zaycev commented 8 months ago

Closing now. @aMySour, @0xD21F, @awski, @00alia00 Lmk if you still see problems.