search

zayronxio / Zafiro-icons

icon pack flat with light colors
GNU General Public License v3.0
438 stars 34 forks source link

Icons on light theme are not always visible #112

Closed tio-trom closed 1 year ago

tio-trom commented 2 years ago

Here it is XFCE with a light theme, using their default text editor: 2022-06-12_05-17 More: 2022-06-12_05-18

Is there an easy fix?

zayronxio commented 2 years ago

for light desktops use opendesktop versions

https://www.pling.com/p/1209330/

tio-trom commented 2 years ago

Yup we ended up doing that. Why aren't them part of this package? Like all of them into one package? Would be easier to keep track of changes and all that.

zayronxio commented 2 years ago

a light and dark version is now available, please try. I await your comments

tio-trom commented 2 years ago

Thanks but installing via any AUR package https://aur.archlinux.org/packages/zafiro-icon-theme or https://aur.archlinux.org/packages/zafiro-icon-theme-git it installs no icon theme. You changed something and these packages are broken now. Can you check please? In the meantime I will try the manual install.

tio-trom commented 2 years ago

They are being installed correctly I think here: 2022-07-11_13-17 But there is soemthing wrong with the package.

tio-trom commented 2 years ago

I see....there should be the Dark and Light folders directly to usr/share/icons folder...even manually you have to add those folders not the master folder ti .local/share/icons. Can you push a fix for this?

tio-trom commented 2 years ago

After manually fixing the issue with this package indeed the Zafiro icons work well with a light theme and a dark theme. So from that perspective this issue can be closed. However we need to fix the issue with how you added the Dark and Light themes to the package so that people can properly install this package. Right now they have to know to copy the Dark and Light folders into the proper folder location on their machine.

zayronxio commented 1 year ago

try this command

wget -N https://raw.githubusercontent.com/zayronxio/Zafiro-icons/master/Install-Zafiro-Icons.sh && chmod +x Install-Zafiro-Icons.sh && bash ./Install-Zafiro-Icons.sh

tio-trom commented 1 year ago

try this command

wget -N https://raw.githubusercontent.com/zayronxio/Zafiro-icons/master/Install-Zafiro-Icons.sh && chmod +x Install-Zafiro-Icons.sh && bash ./Install-Zafiro-Icons.sh

I tried. It does not install them...at least they are not visible in XFCE's settings nor in usr/share/icons or .local/share/icons...

tio-trom commented 1 year ago

Oh I see the scripts adds them into the .icons folder in the Home directory. That's not where icons are usually stored, but in the above mentioned ones.

tio-trom commented 1 year ago

Even if I move that to the proper directory the system can't pick it up since inside the Zafiro master folder there are 2 folders (dark, light) and they need to be in the .local/share/icons....

tio-trom commented 1 year ago

I suggest to rename those as Zafiro-Light and Zafiro-Dark and make sure the script copies those folders directly to .local/share/icons or better usr/share/icons

zayronxio commented 1 year ago

try now

tio-trom commented 1 year ago

Yes now it works great! Mind this line rm: cannot remove '/home/tio/.local/share/icons/github.com': No such file or directory the script has a little bug somewhere but is not a big deal I guess.

Also can you please help with the AUR package now that you changed this. At least to suggest to the maintainer what to add to the PKGBUILD file https://aur.archlinux.org/packages/zafiro-icon-theme-git - so that we make the Zafiro package work.

Thank you!