search

zayronxio / Zafiro-icons

icon pack flat with light colors
GNU General Public License v3.0
438 stars 34 forks source link

Only inherit themes which are really needed #134

Open alexxcons opened 1 month ago

alexxcons commented 1 month ago

Hi Zafiro team,

now that the related xdg merge request got merged and v0.18 of the spec got released, I am starting my mission to get the "Inherits" attribute right for popular icon-themes to prevent potentially missing icons 🙂

Currently Zafiro Light has:

Inherits=Surfn,Adwaita,Numix,Numix-Circle-Light,Numix-Circle,breeze,gnome,hicolor

Zafiro Dark has:

Inherits=hicolor,Adwaita,Surfn,Numix,Numix-Circle,breeze-dark,gnome-dark

I wonder why it inherits from so many other themes ... is Zafiro lacking fd.org icons which need to be provided by one of these?

If there is no strong reason to keep them in the Inherits list, I would suggest dropping all but hicolor.

If one/some of the other themes need to stay on the list for some reason, it makes sense to have a section in the README.md to explain packagers that the zafiro-icon-theme package should have a hard dependency on the other listed themes.