zaytiri / handbrake-recursive-folder-video-converter

An automatic video converter using HandBrake CLI to batch convert all files found in recursive mode. All videos found on folders will be converted on original location while original file will be transfered to another folder for easy removal.
https://pypi.org/project/havc/
MIT License
10 stars 1 forks source link

placeholders reuse #10

Open sochartgit opened 1 month ago

sochartgit commented 1 month ago

Hi, I try to pass {of} twice in the -cc command. It's replaced only in the first occurence. The goal is to pass the subtitle filename like that: More than this, adding .srt extension does not work properly.

havc -r C:\Users\socha\scoop\apps\handbrake-cli\current -c "c:\TEST" -e mp4 -t mkv -cc "--preset 'Very Fast 2160p60 4K AV1' --all-subtitles --srt-file {of}.srt -i {of} -o {cf}"

Is there a way to use the input filename with .srt extension as default filename for the corresponding subtitle file ?

zaytiri commented 1 month ago

I see your issue and indeed I do not reuse the placeholders. It just replaces the first one. But this should be an easy change and one that I did not take into consideration the first time. But I can definitely see the use case for this. I'll see what I can do about this and let you know. Thank you for pointing this out. I can maybe have an update in a day or two, if you could wait it would be appreciated.

zaytiri commented 1 month ago

I just released version 1.4.0 which should contain the solution to this problem.

Let me know if it works fine for you so we can also close this issue. Thanks!