search

zaytri / slime2

Local Chat Overlay System for Twitch
https://slime2.stream/
32 stars 7 forks source link

Ensure channel is connected to if chatClient's connection cycles #20

Closed navarr closed 7 months ago

navarr commented 8 months ago

At current, if the websocket gets interrupted, chatClient will open a new connection to the Twitch IRC Websocket interface, but will not rejoin the broadcaster's channel

zaytri commented 8 months ago

oh thanks when does this happen? is it when a streamer loses internet connection for a bit?

navarr commented 8 months ago

oh thanks when does this happen? is it when a streamer loses internet connection for a bit?

I would assume so. For me, I was testing stuff and left it running overnight in a chrome window. The connection closed when I locked my computer, and opened a new one when I started - and inspecting the websocket connections I saw it didn't rejoin.

It's testable by using webtools to set throttling to "offline" at which point twurple will assume the connection has dropped after a failed PING, and open a new one. Turning throttling back to "none" will then allow a connection to establish.

I'm unsure what exactly will happen in OBS, but I'm confident a similar situation for any kind of network hiccup that might happen during stream, or leaving OBS open for multiple days at a time.

zaytri commented 8 months ago

awesome, I'll pull this into v1.2 later

zaytri commented 7 months ago

pulling this into the small pronouns update today since it'll likely become obsolete once I switch to using Twitch's EventSub chat instead of IRC