zazi1991i / harviewer

Automatically exported from code.google.com/p/harviewer
0 stars 0 forks source link

Patch: Fix CSS warnings #46

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Not sure if this is a correct fix since I'm not 100% sure how domplate works, 
but here's a patch that seems to fix the issue of all the "Error in parsing 
value for 'left'.  Declaration dropped." warnings that happen in Firefox.  It 
seems that $file.offset and $file.width are undefined.

--- webapp/scripts/preview/requestList.js   (revision 296)
+++ webapp/scripts/preview/requestList.js   (working copy)
@@ -91,12 +91,12 @@
                 TD({"class": "netTimeCol netCol"},
                     DIV({"class": "netTimelineBar"},
                         " ",
-                        DIV({"class": "netResolvingBar netBar", style: "left: 
$file.offset"}),
-                        DIV({"class": "netConnectingBar netBar", style: "left: 
$file.offset"}),
-                        DIV({"class": "netBlockingBar netBar", style: "left: 
$file.offset"}),
-                        DIV({"class": "netSendingBar netBar", style: "left: 
$file.offset"}),
-                        DIV({"class": "netWaitingBar netBar", style: "left: 
$file.offset"}),
-                        DIV({"class": "netReceivingBar netBar", style: "left: 
$file.offset; width: $file.width"},
+                        DIV({"class": "netResolvingBar netBar"}),
+                        DIV({"class": "netConnectingBar netBar"}),
+                        DIV({"class": "netBlockingBar netBar"}),
+                        DIV({"class": "netSendingBar netBar"}),
+                        DIV({"class": "netWaitingBar netBar"}),
+                        DIV({"class": "netReceivingBar netBar"},
                             SPAN({"class": "netTimeLabel"}, "$file|getElapsedTime")
                         )
                         // Page timings (vertical lines) are dynamically appended here.

Original issue reported on code.google.com by adrian...@gmail.com on 3 Jun 2011 at 11:24

GoogleCodeExporter commented 8 years ago
Yep, nice catch, patch committed at R298

Thanks!
Honza

Original comment by odva...@gmail.com on 4 Jun 2011 at 11:29

GoogleCodeExporter commented 8 years ago
This issue is one of 6 fixed in HAR Viewer 2.0.11
You can check it online here:
http://www.softwareishard.com/har/viewer/

Or download a distribution package from here:
http://code.google.com/p/harviewer/downloads/list

Read release notes here:
http://code.google.com/p/harviewer/wiki/ReleaseNotes

Honza

Original comment by odva...@gmail.com on 16 Jun 2011 at 4:14

GoogleCodeExporter commented 8 years ago
This issue is one of 6 fixed in HAR Viewer 2.0.11
You can check it online here:
http://www.softwareishard.com/har/viewer/

Or download a distribution package from here:
http://code.google.com/p/harviewer/downloads/list

Read release notes here:
http://code.google.com/p/harviewer/wiki/ReleaseNotes

Honza

Original comment by odva...@gmail.com on 16 Jun 2011 at 4:14

GoogleCodeExporter commented 8 years ago
This issue is one of 6 fixed in HAR Viewer 2.0.11
You can check it online here:
http://www.softwareishard.com/har/viewer/

Or download a distribution package from here:
http://code.google.com/p/harviewer/downloads/list

Read release notes here:
http://code.google.com/p/harviewer/wiki/ReleaseNotes

Honza

Original comment by odva...@gmail.com on 16 Jun 2011 at 4:14