search

zazi1991i / harviewer

Automatically exported from code.google.com/p/harviewer
0 stars 0 forks source link

Event handling and IE #50

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
HAR Viewer currently uses a mix of jQuery and direct DOM method access.  This 
leads to issues in some spots where it isn't fully cross-browser compatible.  
One example is event handling.

In harViewer.js, it uses Lib.fireEvent() to fire the onPreviewPreInit, etc 
events.  However, fireEvent() doesn't work for IE8 (maybe it was IE7) and below 
due to them not supporting the createEvent/dispatchEvent methods.

Would it be better to use jQuery's event handling for things like the 
onPreviewPreInit/etc events?  In the API documentation, you're using jQuery to 
bind the events, so it makes sense to use it to trigger the events as well.

Original issue reported on code.google.com by adrian...@gmail.com on 13 Jun 2011 at 8:01

GoogleCodeExporter commented 8 years ago 
Yes, agree.

Honza

Original comment by odva...@gmail.com on 13 Jun 2011 at 8:14

GoogleCodeExporter commented 8 years ago 
Hi!

Looks like it wouldn't work in Opera either. And unfortunately it breaks some 
API.

Any plans regarding this defect? Do you accept patches?

Original comment by Pavel.Pa...@gmail.com on 10 Jan 2012 at 2:54

GoogleCodeExporter commented 8 years ago 
> Do you accept patches?
yes, please!

Honza

Original comment by odva...@gmail.com on 10 Jan 2012 at 3:07