zazuko / barnard59

An intuitive and flexible RDF pipeline solution designed to simplify and automate ETL processes for efficient data management.
26 stars 2 forks source link

feat(csvw): types #309

Closed tpluscode closed 5 months ago

tpluscode commented 5 months ago

Unlike most other packages, I actually changed the source to TS because I had trouble annotating the types just right. You'll see that mostly in lib/fetchMetadata.ts

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: b4936e9b48e096f44dc005ea4a7455e96f7ee3d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | barnard59-csvw | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 87.27273% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.48%. Comparing base (bee1ca9) to head (b4936e9).

Files Patch % Lines
packages/csvw/filter.ts 0.00% 4 Missing :warning:
packages/csvw/lib/fetchMetadata.ts 87.50% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #309 +/- ## ========================================== - Coverage 84.52% 84.48% -0.04% ========================================== Files 173 173 Lines 6977 6987 +10 Branches 102 112 +10 ========================================== + Hits 5897 5903 +6 - Misses 1078 1082 +4 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | Coverage Δ | | |---|---|---| | [barnard59](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `81.31% <ø> (ø)` | | | [barnard59-core](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `90.92% <ø> (ø)` | | | [barnard59-csvw](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `78.21% <87.27%> (-2.01%)` | :arrow_down: | | [barnard59-cube](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `96.46% <ø> (ø)` | | | [barnard59-formats](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `28.17% <ø> (ø)` | | | [barnard59-ftp](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `97.60% <ø> (ø)` | | | [barnard59-graph-store](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `95.10% <ø> (ø)` | | | [barnard59-http](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `87.50% <ø> (ø)` | | | [barnard59-rdf](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `94.84% <ø> (ø)` | | | [barnard59-s3](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `100.00% <ø> (ø)` | | | [barnard59-shacl](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `51.96% <ø> (ø)` | | | [barnard59-sparql](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `94.93% <ø> (ø)` | | | [barnard59-validation](https://app.codecov.io/gh/zazuko/barnard59/pull/309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko) | `97.53% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zazuko#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.