search

zazuko / clownface

Simple but powerful graph traversing library for RDF
https://zazuko.github.io/clownface/
37 stars 8 forks source link

fix: mixing clownface version breaks on language #46

Closed tpluscode closed 4 years ago

tpluscode commented 4 years ago

This fixes a subtle problem which arises from multiple versions of clownface (0.12 & 1.0) which might be installed through incompatible transitive dependencies

Version 0.12 does not have languages and thus will call Context#out without the second parameter. It does not have a default value and will thus fail to restructure when undefined

codecov-commenter commented 4 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files           9        9           
  Lines         276      276           
=======================================
  Hits          271      271           
  Misses          5        5
Impacted Files Coverage Δ
lib/Context.js 98.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1a4500...59e80d4. Read the comment docs.