zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
12 stars 2 forks source link

fix: no blank cube warnings #1313

Closed tpluscode closed 1 year ago

tpluscode commented 1 year ago

I noticed one more small issue, that instead of removing an error completely when it no longer applies to a given cube, empty yellow rows remain in the cube designer.

image

That is because the SPARQL removed the error details but not the error node itself.

<dataset>
  schema:error <dataset#error-id> .

# This was removed but the above was not
<dataset#error-id>
  schema:description "Displayed on UI" .

This PR makes sure that the errors are properly cleaned

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: fe9f29133d644667d55c0d1f2f65b30e697016f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | @cube-creator/core-api | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #1313 (fe9f291) into master (7b689c2) will decrease coverage by 6.02%. The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   81.45%   75.42%   -6.03%     
==========================================
  Files         192      193       +1     
  Lines       13391    13390       -1     
  Branches      751      694      -57     
==========================================
- Hits        10907    10099     -808     
- Misses       2477     3284     +807     
  Partials        7        7              
Impacted Files Coverage Δ
apis/core/lib/domain/errors/deleteCurrent.ts 28.57% <28.57%> (ø)
apis/core/lib/domain/errors/missingDimensions.ts 16.39% <40.00%> (+3.89%) :arrow_up:
...is/core/lib/domain/errors/duplicateObservations.ts 20.00% <50.00%> (+5.24%) :arrow_up:
packages/model/Dataset.ts 100.00% <100.00%> (ø)
cli/lib/pipeline.ts 0.00% <0.00%> (-100.00%) :arrow_down:
cli/lib/import/cube.ts 0.00% <0.00%> (-100.00%) :arrow_down:
cli/lib/toCubeShape/Cube.js 0.00% <0.00%> (-100.00%) :arrow_down:
cli/lib/toCubeShape/urlJoin.js 0.00% <0.00%> (-100.00%) :arrow_down:
cli/lib/toCubeShape/Dimension.js 0.00% <0.00%> (-100.00%) :arrow_down:
cli/lib/import/dimensions.ts 0.00% <0.00%> (-97.92%) :arrow_down:
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.