zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
14 stars 2 forks source link

Creating a Shared Dimension fails - Blocker #1319

Closed FabianCretton closed 1 year ago

FabianCretton commented 2 years ago

Cube Creator version 1.12.9 Tried on TEST and INT

image

FabianCretton commented 2 years ago

and same remark as always: would it be possible to get real information when an error occurs ?

FabianCretton commented 2 years ago

another question: don't you have any validation test, unit tests, acceptance tets, etc... so that we do not go back in time when features that work become unstable later ? a honest question, I am interested in what exists and how the system is tested

FabianCretton commented 2 years ago

@l00mi any update on this ? My only workaround so far is to show Tobias how to create Shared Dimension through .trig upload

l00mi commented 2 years ago

@tpluscode did some work here, not sure if this is fixed too. @tpluscode ?

tpluscode commented 2 years ago

The reason here is simple. When created using the form, the "identifier" field is required to consist only of letters, number and a hyphen.

This is nothing new, as well as the lacking display of errors which is unfortunately problematic with more complex SHACL shapes. Interestingly too, it was never caught that the shared dimension import does not put the same restriction on the identifier property.

In that regard, is that validation unnecessarily strict maybe and should be relaxed? @l00mi

FabianCretton commented 2 years ago

@tpluscode @l00mi waa...yes, it works with hyphen, not with underscore, why is that ? Especially that, on the other side, the identifier field for a cube says:

Cube identifier
A unique, URL-safe string to identify the cube (only letters, digits, -, . and _)

I let you think about user experience and what to do for the best Thanks

l00mi commented 1 year ago

Lets add the underscores to the allowed characters to be in sync with the field.

FabianCretton commented 1 year ago

I see today that, on the CSV Mapping, the underscores are not permitted in the 'Target Property' field. I let you decide how to "harmonize" the permitted symbols