Closed tpluscode closed 1 year ago
Merging #1322 (9a904de) into master (fa62fb7) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1322 +/- ##
==========================================
+ Coverage 81.51% 81.52% +0.01%
==========================================
Files 193 193
Lines 13390 13398 +8
Branches 751 751
==========================================
+ Hits 10915 10923 +8
Misses 2468 2468
Partials 7 7
Impacted Files | Coverage Δ | |
---|---|---|
...s/shared-dimensions/lib/shapes/shared-dimension.ts | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@l00mi quick opinion, which would be better
or inline
Gut feeling goes for the first option, especially as you bring a good point. If the Titles will be used in future for Front-End we should also show them in all languages.
But potentially we should introduce also the language drop-down here.
Right, I missed the fact that the name is also multilingual but we only display one. Yes, this should be more like the cube designer, where you can switch the language...
Would you keep the abbreviations displayed in all languages now?
No, if we have a "language switch" i propose to show one language only.
Then question is whether we add that dropdown now
@tpluscode one more thing, if you have this already in focus.
Please hide the 'deprecated' shared dimensions, and add a checkmark on top to show them. Simply:
[ ] deprecated (which by default is not checked)
🦋 Changeset detected
Latest commit: 9a904deca95cbd36228332c58a1605a8937c2f2f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
| Name | Type | | ----------------------------------- | ----- | | @cube-creator/ui | Minor | | @cube-creator/shared-dimensions-api | Minor | | @cube-creator/core-api | Patch |Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR