fix: clearing values when switching sh:xone form alternatives

[tpluscode]

To improve the editor switch similarly to what we do in view builder

Cube Creator.webm

Since that was introduced in a breaking release of shaperone, some more changes were necessary to fix the usage of select/combobox form controls. A lot could actually be simplified now, especially that @hydrofoil/shaperone-hydra now comes with a baseline implementation for the dash:AutoCompleteEditor

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: bdec315e10bdfc943ee0761fe7608fb39e0bb853

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ---------------- | ----- | | @cube-creator/ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov-commenter]

Codecov Report

Merging #1339 (bdec315) into master (05708f3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1339   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files         195      195           
  Lines       13508    13508           
  Branches      753      753           
=======================================
  Hits        10947    10947           
  Misses       2553     2553           
  Partials        8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[cristianvasquez]

However, UI-wise, I'm unsure if that is the user expectation that the form 'forgets' previous inputs.

[cristianvasquez]

I know why. The XoR looks a bit like a tabbed options panel.

I don't know how to make it look more as an exclusive or

[tpluscode]

However, UI-wise, I'm unsure if that is the user expectation that the form 'forgets' previous inputs.

Interesting observation. I hope it's a viable compromise though. It would require deeper changes to actually clear the unwanted values of unselected xone properties in a different way. Granted, inadvertently switching the selector, forces to redo selection when you go back but at least it fixes the current problem that it is impossible to unselect from a dropdown and the validation finds a violation.