Closed tpluscode closed 1 year ago
Latest commit: 810440614c5989d099c9341b61baf762b1e8e29e
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Merging #1357 (8104406) into master (4325eba) will decrease coverage by
61.72%
. The diff coverage is5.52%
.
@@ Coverage Diff @@
## master #1357 +/- ##
===========================================
- Coverage 81.04% 19.32% -61.73%
===========================================
Files 195 197 +2
Lines 13506 13379 -127
Branches 754 105 -649
===========================================
- Hits 10946 2585 -8361
- Misses 2552 10794 +8242
+ Partials 8 0 -8
Impacted Files | Coverage Δ | |
---|---|---|
...s/shared-dimensions/lib/domain/shared-dimension.ts | 0.00% <0.00%> (-92.15%) |
:arrow_down: |
...d-dimensions/lib/domain/shared-dimension/import.ts | 0.00% <0.00%> (-97.98%) |
:arrow_down: |
...-dimensions/lib/domain/shared-dimension/queries.ts | 0.00% <0.00%> (ø) |
|
apis/shared-dimensions/lib/loader.ts | 0.00% <0.00%> (-84.06%) |
:arrow_down: |
apis/shared-dimensions/lib/rewrite.ts | 0.00% <0.00%> (-86.37%) |
:arrow_down: |
apis/shared-dimensions/lib/store.ts | 0.00% <0.00%> (-93.59%) |
:arrow_down: |
apis/shared-dimensions/lib/store/index.ts | 0.00% <0.00%> (ø) |
|
apis/shared-dimensions/lib/store/shapes.ts | 0.00% <0.00%> (ø) |
|
packages/testing/lib/seedData.ts | 55.68% <39.13%> (-41.29%) |
:arrow_down: |
packages/core/namespace.ts | 100.00% <100.00%> (ø) |
|
... and 144 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Big change to how shared dimensions and hierarchies are stored in the database
Currently, every save resource is saved alongside a SHACL shape to describe its properties. This proved difficult to query and manage in runtime. Additionally, all blank nodes would have been replaced with
urn:
identifiers which only added to the code necessary to process the API calls.As a result, some queries became slow and the the shared dimensions graph bloated with excess triples.
To mitigate that, the process is being simplified so that the resources will be saved with blank nodes intact and retrieved using predefined shapes for specific typed (dimension, dimension term, hierarchy, etc)
A one-time data cleanup is advised.
First, create a backup of the graph
<https://lindas.admin.ch/cube/dimension>
. Just in caseUse the queries below to export only the important data. They are similar to queries the API will run but also ensure that
urn:
identifiers are changed to blank nodes.Export Dimensions
```sparql PREFIX rdf:Export Dimension Terms
```sparql PREFIX rdf:Export Hierarchies
```sparql PREFIX rdf:Then clear the graph
<https://lindas.admin.ch/cube/dimension>
and upload the exported data to it.Finally, restart the app