zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
12 stars 2 forks source link

build(deps): update opentelemetry #1377

Closed tpluscode closed 1 year ago

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 38a01143e9bc0d209f80e1835b556bdcb0696884

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @cube-creator/cli | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #1377 (38a0114) into master (5a7262e) will decrease coverage by 0.08%. The diff coverage is 51.28%.

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
- Coverage   80.84%   80.77%   -0.08%     
==========================================
  Files         197      196       -1     
  Lines       13383    13399      +16     
  Branches      736      736              
==========================================
+ Hits        10820    10823       +3     
- Misses       2555     2568      +13     
  Partials        8        8              
Impacted Files Coverage Δ
cli/lib/otel/index.ts 0.00% <0.00%> (ø)
cli/server.ts 0.00% <0.00%> (ø)
cli/lib/bufferDebug.ts 97.64% <100.00%> (-0.14%) :arrow_down:
cli/lib/counters.ts 100.00% <100.00%> (ø)
apis/core/lib/domain/queries/dimension-mappings.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tpluscode commented 1 year ago

Jaeger traces are back when I applied your changes but no metrics are being collected still

I'm pretty sure that I am configuring something wrong. Compared to the example you showed me @ludovicm67, I am using NodeSDK class. However when I added the metric reader argument, it would fail with Error: MetricReader can not be bound to a MeterProvider again.

On the other hand, similarly to you code, @opentelemetry/exporter-metrics-otlp-http shows usage where the meter provider is used directly and it should "just work".

And yet, cube-creator's metrics do show up in prometheus. Any ideas?