Closed ludovicm67 closed 1 year ago
Latest commit: cd5936ffc2425afc8344e2f34406aca4b1586c52
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Merging #1384 (cd5936f) into otel-upgrade (73e2243) will decrease coverage by
0.10%
. The diff coverage is34.48%
.
@@ Coverage Diff @@
## otel-upgrade #1384 +/- ##
================================================
- Coverage 80.82% 80.72% -0.10%
================================================
Files 197 196 -1
Lines 13389 13387 -2
Branches 734 808 +74
================================================
- Hits 10822 10807 -15
- Misses 2559 2572 +13
Partials 8 8
Impacted Files | Coverage Δ | |
---|---|---|
cli/lib/otel/index.ts | 0.00% <0.00%> (ø) |
|
cli/server.ts | 0.00% <0.00%> (ø) |
|
cli/lib/bufferDebug.ts | 97.64% <100.00%> (+0.11%) |
:arrow_up: |
cli/lib/counters.ts | 100.00% <100.00%> (ø) |
|
apis/shared-dimensions/lib/domain/resource.ts | 54.02% <0.00%> (-10.35%) |
:arrow_down: |
cli/lib/import/dimensions.ts | 92.36% <0.00%> (-5.56%) |
:arrow_down: |
packages/express/multipart.ts | 89.02% <0.00%> (-4.88%) |
:arrow_down: |
packages/model/lib/uriTemplateParser.js | 89.06% <0.00%> (-4.69%) |
:arrow_down: |
cli/lib/auth.ts | 91.66% <0.00%> (-4.63%) |
:arrow_down: |
apis/shared-dimensions/lib/rewrite.ts | 46.66% <0.00%> (-3.34%) |
:arrow_down: |
... and 21 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Some suggestions for the
otel-upgrade
branch:cli/server.ts
is importantfinally
incli/server.ts
is not required, since it's a process that is always running ; and it was directly calling the shutdown, which is not something we wantcli/lib/otel/metrics.ts
and moved the metrics in the relevant files ; this was also to be sure that things gets initialized in the right order