search

zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
11 stars 2 forks source link

Missing validation when importing shared dimension #1385

Closed tpluscode closed 1 year ago

tpluscode commented 1 year ago

When importing a shared dimension, the identifier rule is not correctly applied. Maybe other SHACL rules too

Affected functionalities (all that apply)

Relevant links

https://zulip.zazuko.com/#narrow/stream/63-cube-creator/topic/camelCase/near/323647

To Reproduce Steps to reproduce the behavior:

  1. Export a shared dimension
  2. Edit the file manually (change identifiers to camelCase
  3. Import
  4. No error

Expected behavior

All validation rules should be applied, same to those running when editing shared dimensions with the UI

tpluscode commented 1 year ago

Actually, the behaviour may be correct after all. When I wrote to "change identifiers", it would have meant the URI but validation applies to the dcterms:identifier. These identifier are no longer present as literals and thus cannot be verified

Bottom line, URLs are not that important and if modified they will still continue to function.