zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
11 stars 2 forks source link

fix: relax patterns for shared dimension identifiers #1388

Closed tpluscode closed 1 year ago

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: b6dec1cecc0c447b57edc897b4138717cca72500

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ----------------------------------- | ----- | | @cube-creator/shared-dimensions-api | Patch | | @cube-creator/core-api | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #1388 (b6dec1c) into master (9cbb7d9) will decrease coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
- Coverage   80.86%   80.76%   -0.10%     
==========================================
  Files         197      197              
  Lines       13395    13411      +16     
  Branches      736      736              
==========================================
  Hits        10832    10832              
- Misses       2555     2571      +16     
  Partials        8        8              
Impacted Files Coverage Δ
...red-dimensions/lib/shapes/shared-dimension-term.ts 100.00% <100.00%> (ø)
...s/shared-dimensions/lib/shapes/shared-dimension.ts 100.00% <100.00%> (ø)
cli/lib/counters.ts 92.30% <0.00%> (-7.70%) :arrow_down:
cli/server.ts 0.00% <0.00%> (ø)
cli/lib/otel/index.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

giacomociti commented 1 year ago

looks good to me, thanks