zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
11 stars 2 forks source link

When a transformation is needed, a message was supposed to be displayed to the user ? #1413

Closed FabianCretton closed 1 year ago

FabianCretton commented 1 year ago

On step 3, when we map a dimension to a Shared Dimension, we then need to go back to Step 2 and transform again, right ? And we talked about having a user message to inform him when a new transformation is needed, but if I am not mistaken, there is no information displayed after a new Shared Dimension mapping.

Thank you for any input

tpluscode commented 1 year ago
image

This message should be displayed

FabianCretton commented 1 year ago

@tpluscode do you mean that this is working, or that this should be done ? Yesterday Tobias contacted me because of a mapping problem, and it was because he did not run the transform again, so I guess he never saw the message

tpluscode commented 1 year ago

Yes, this message is already shown after mapping. So unless there are specific circumstances in which it does not, I might assume that Tobias simply missed it

FabianCretton commented 1 year ago

@tpluscode is the message always present when you re-open the cube, or only just after doing the mapping ?

tpluscode commented 1 year ago

This message is persistent, displayed in the Cube Designer screen

FabianCretton commented 1 year ago

So, I did not see the message this morning when opening his cube

FabianCretton commented 1 year ago

See his cube: https://int.cube-creator.lindas.admin.ch/app/cube-projects/cube-project!!swissprtronlytrucatedpq2-g21lpjwoq9/metadata Dimension 'Betriebs ID' I will ask him to wait before transforming

FabianCretton commented 1 year ago

Another curiosity, if you look at this: Very strangely, on that cube, if you open the mapping -> each value has 2 entries, for instance "101", one being mapped, the other one not: image

tpluscode commented 1 year ago

That is quite curious. Maybe related to #1314. I will look into that

tpluscode commented 1 year ago

Another curiosity, if you look at this:

I found this behaviour being caused by data type of Betriebs ID. The mapping itself is string => shared term but the IDs are numbers. (The identifiers of that particular dimension are string too, but that may be irrelevant)

Bottom line, I think the mapping should operate on the raw string value of a mapped dimension. @l00mi

FabianCretton commented 1 year ago

Sorry @tpluscode that we mixed two things in this talk. I think you talk here about why we see twice each value, right ?

But what about the 'transform' message that do not show up, did you find anything or is it a mistake on my side ?

tpluscode commented 1 year ago

Yes, I can also confirm that the message did not appear as it should have. Will handle that next.

I focus on the mapping itself because the string vs number mismatch actually breaks the mapping functionality. I mean, yes it would be possible to work around by mapping from CSV to string but I think it's an unnecessary restriction

FabianCretton commented 1 year ago

Thanks, I thus wait for your update

tpluscode commented 1 year ago

I did find two circumstances when the warning was not displayed: when auto-filling the mapping and when mapped pairs were removed only, without adding any new. Both being fixed now

tboeni commented 1 year ago

@tpluscode I only just saw this thread. Maybe to give a bit of clarification from my part: It indeed was done via auto-filling the mapping from a shared dimension i created earlier. However when doing the transformation even without the displayed warning message the SD for some reason did not link properly (or at all for that matter). This is the Cube in question

tpluscode commented 1 year ago

Than you for the clarification @tboeni. I believe both your problems will be fixed with next release