zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
11 stars 2 forks source link

fix: mapping dimension with typed literals #1418

Closed tpluscode closed 1 year ago

tpluscode commented 1 year ago

Typed literals would not be correctly replaced with shared dimension terms because the comparison was done strictly, according to RDF rules

This PR relaxes that and compares the values as their plain literal representations

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: dfadb351e14863b10995f8b5c40156d3c9f80e93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ---------------------- | ----- | | @cube-creator/core-api | Patch | | @cube-creator/ui | Patch | | @cube-creator/cli | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #1418 (ddd7ee9) into master (e84480c) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1418      +/-   ##
=========================================
- Coverage    0.18%   0.18%   -0.01%     
=========================================
  Files         171     171              
  Lines       11798   11801       +3     
=========================================
  Hits           22      22              
- Misses      11776   11779       +3     
Impacted Files Coverage Δ
...e/lib/domain/dimension-mapping/DimensionMapping.ts 0.00% <0.00%> (ø)
apis/core/lib/domain/dimension-mapping/update.ts 0.00% <0.00%> (ø)
cli/lib/output-mapper.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tpluscode commented 1 year ago

Ah, I intended to create a second PR but I suppose that it's not that big and changes are related.

I also pushed now fixes which ensure that a warning is added to project when a dimension mapping is modified using the auto-fill feature and when pairs are removed