search

zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
11 stars 2 forks source link

feat: inline shacl violations #1419

Closed tpluscode closed 1 year ago

tpluscode commented 1 year ago

Not perfect but at least some field will start showing inline errors

Problematic cases include nested forms and dynamic, conditional fields. For those it's not that easy to figure out that a given error should be rendered where

https://user-images.githubusercontent.com/588128/230398895-92dc54fc-e72b-4a2d-b2bd-a41c4ca66a61.mp4

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 6e2acb70455413577a618129fe0a1422a1578243

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @cube-creator/ui | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #1419 (3fd48ed) into master (55c3333) will increase coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
+ Coverage   80.58%   80.62%   +0.03%     
==========================================
  Files         196      196              
  Lines       13486    13496      +10     
  Branches      814      830      +16     
==========================================
+ Hits        10868    10881      +13     
+ Misses       2610     2607       -3     
  Partials        8        8

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.