zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
11 stars 2 forks source link

feat: add new profiles #1420

Closed dabo505 closed 1 year ago

dabo505 commented 1 year ago

Two new profiles and some adjustments to OFCOM. Please merge if everything looks good...

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: eefb4d9b9b02a07c5e97a97cd49f4c974127bbd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | @cube-creator/core-api | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #1420 (eefb4d9) into master (6f03fac) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   80.60%   80.60%           
=======================================
  Files         196      196           
  Lines       13496    13496           
  Branches      817      817           
=======================================
  Hits        10878    10878           
  Misses       2610     2610           
  Partials        8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dabo505 commented 1 year ago

This time https://transport.ld.admin.ch/ has an invalid certificate. health domain works fine.

Looks good otherwise.

Thanks for the hint, I forwarded it to BAR.

l00mi commented 1 year ago

ObservedBy should be ld.admin.ch/office/ namespace.On 11 Apr 2023 16:01, David Bokel @.***> wrote:

This time https://transport.ld.admin.ch/ has an invalid certificate. health domain works fine. Looks good otherwise.

Thanks for the hint, I forwarded it to BAR.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

dabo505 commented 1 year ago

ObservedBy should be ld.admin.ch/office/ namespace.On 11 Apr 2023 16:01, David Bokel @.> wrote: This time https://transport.ld.admin.ch/ has an invalid certificate. health domain works fine. Looks good otherwise. Thanks for the hint, I forwarded it to BAR. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.>

Yes, but it doesn't exist for BAKOM afaik.

l00mi commented 1 year ago

https://ld.admin.ch/office/VII.1.6

tpluscode commented 1 year ago

Good to merge @l00mi @dabo505 ?