zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
11 stars 2 forks source link

fix: use only clownface for mappings to reduce memory #1449

Closed tpluscode closed 1 year ago

tpluscode commented 1 year ago

Using the strongly-types interface for manipulating (large) dimension mappings was quite memory-intensive to the point where pods were being restarted

This changes this process to use clownface directly

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 82c9d1ac7c01b5a9a3095c82a51c5d15c5b70e14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | @cube-creator/core-api | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #1449 (82c9d1a) into master (715b162) will increase coverage by 0.00%. The diff coverage is 97.22%.

@@           Coverage Diff           @@
##           master    #1449   +/-   ##
=======================================
  Coverage   80.32%   80.32%           
=======================================
  Files         198      198           
  Lines       13646    13648    +2     
  Branches      829      827    -2     
=======================================
+ Hits        10961    10963    +2     
+ Misses       2677     2676    -1     
- Partials        8        9    +1     
Impacted Files Coverage Δ
...e/lib/domain/dimension-mapping/DimensionMapping.ts 96.80% <96.55%> (+0.02%) :arrow_up:
apis/core/lib/domain/dimension-mapping/update.ts 100.00% <100.00%> (ø)