Open mchlrch opened 7 months ago
Latest commit: 440952874528fc121d3ad1541e4789c07354aea0
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Attention: Patch coverage is 92.40506%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 80.42%. Comparing base (
dd4cba3
) to head (4409528
). Report is 5 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
apis/core/lib/domain/cube-projects/create.ts | 82.35% | 3 Missing :warning: |
apis/core/lib/domain/cube-projects/import.ts | 70.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Where should the flag show up in UI?
Please add a test scenario in
cli/test/lib/commands/publish.test.ts
which checks that publishing a hidden cube writes to the expected graph
I added a unit test here: apis/core/test/domain/job/create.test.ts
cubes metadataProject..../hidden
graph