zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
13 stars 2 forks source link

Support for hidden cubes #1485

Open mchlrch opened 7 months ago

mchlrch commented 7 months ago
changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: 440952874528fc121d3ad1541e4789c07354aea0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 92.40506% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 80.42%. Comparing base (dd4cba3) to head (4409528). Report is 5 commits behind head on master.

Files Patch % Lines
apis/core/lib/domain/cube-projects/create.ts 82.35% 3 Missing :warning:
apis/core/lib/domain/cube-projects/import.ts 70.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1485 +/- ## ========================================== + Coverage 80.36% 80.42% +0.06% ========================================== Files 199 200 +1 Lines 13676 13745 +69 Branches 829 836 +7 ========================================== + Hits 10991 11055 +64 - Misses 2676 2681 +5 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mchlrch commented 7 months ago

Where should the flag show up in UI?

image

image

image

image

image

mchlrch commented 6 months ago

Please add a test scenario in cli/test/lib/commands/publish.test.ts which checks that publishing a hidden cube writes to the expected graph

I added a unit test here: apis/core/test/domain/job/create.test.ts