search

zazuko / cube-creator

A tool to create RDF cubes from CSV files
GNU Affero General Public License v3.0
13 stars 2 forks source link

improve validation: ensure consistent observedBy in ObservationConstraint #1508

Closed Rdataflow closed 1 week ago

Rdataflow commented 5 months ago
changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: f2a8da1162bc55d8edf57578adc905feca5ebe1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Rdataflow commented 5 months ago

@tpluscode would you mind starting the CI test ?

Rdataflow commented 3 weeks ago

@tpluscode it seems the current workflow injects/overrides the observer but only in the observations...

How would it be possible to set the observer globally (observations, shape)? would it i.e. make more sense to pass the observer argument in the transform step already (instead of injection) WDYT?

feel free to build upon theese crafted commits... it's at your disposition 👍